-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: suggest compaction when replicas are deleted #21178
storage: suggest compaction when replicas are deleted #21178
Conversation
Reviewed 5 of 5 files at r1. pkg/storage/client_raft_test.go, line 3898 at r1 (raw file):
The compaction could also be processed (maybe not in today's code, but in principle), so check there's something queued or processed or skipped. pkg/storage/client_raft_test.go, line 3904 at r1 (raw file):
Ditto. Comments from Reviewable |
2048b19
to
cf2002d
Compare
Review status: 4 of 5 files reviewed at latest revision, 2 unresolved discussions. pkg/storage/client_raft_test.go, line 3898 at r1 (raw file): Previously, tschottdorf (Tobias Schottdorf) wrote…
Done. pkg/storage/client_raft_test.go, line 3904 at r1 (raw file): Previously, tschottdorf (Tobias Schottdorf) wrote…
Done. Comments from Reviewable |
cf2002d
to
aa1a097
Compare
Reviewed 1 of 1 files at r2. Comments from Reviewable |
aa1a097
to
8862b5d
Compare
@tschottdorf note that in the process of testing this with an actual migration, I noticed some other problems, which I've updated this commit to fix. PTAL. |
Review status: 3 of 5 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Reviewed 2 of 2 files at r3. Comments from Reviewable |
8862b5d
to
79906c2
Compare
In aggregate, if enough contiguous replicas are migrated away from a range, we would like to compact the underlying RocksDB storage engine. To that end, on clear a replica's data, we suggest a compaction. Fixed various bugs with the compactor queue - in particular, the call in the main processing loop to stop the timer was misplaced and caused the timer to be permanently disabled. Also, fixed an indexing error in log messages and updated comments. Release note: None
79906c2
to
25744b2
Compare
In aggregate, if enough contiguous replicas are migrated away from a
range, we would like to compact the underlying RocksDB storage engine.
To that end, on clear a replica's data, we suggest a compaction.
Release note: None